-
Notifications
You must be signed in to change notification settings - Fork 2
Implement energy-reset button for energy devices #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@bouwew has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis update removes the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant PlugwiseUSBIntegration
participant PlugwiseDevice
User->>HomeAssistant: Presses "energy_reset" button
HomeAssistant->>PlugwiseUSBIntegration: Handles button press
PlugwiseUSBIntegration->>PlugwiseDevice: Calls energy_reset_request
PlugwiseDevice-->>PlugwiseUSBIntegration: Resets energy logs
PlugwiseUSBIntegration-->>HomeAssistant: Confirms reset
HomeAssistant-->>User: Button action complete
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
5f4aec6 to
a21d18a
Compare
35b527f to
81a7e80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
8-9: Clarify the bullet description.
- Combine these lines into one clear sentence.
- Replace “to address 0” with “to zero” (or “to 0”), e.g.:
“Implement an energy-reset button for energy devices that resets the device’s energy collection data to zero, overwriting existing values.”
10-10: Improve phrasing for readability.
Consider rephrasing as:
“Improve the energy-reset process to reduce ZigBee traffic, network load, and server processor usage.”
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
CHANGELOG.md(1 hunks)custom_components/plugwise_usb/__init__.py(0 hunks)custom_components/plugwise_usb/button.py(1 hunks)custom_components/plugwise_usb/manifest.json(1 hunks)custom_components/plugwise_usb/services.yaml(0 hunks)custom_components/plugwise_usb/strings.json(1 hunks)custom_components/plugwise_usb/translations/en.json(1 hunks)custom_components/plugwise_usb/translations/nl.json(1 hunks)requirements_test.txt(1 hunks)
💤 Files with no reviewable changes (2)
- custom_components/plugwise_usb/services.yaml
- custom_components/plugwise_usb/init.py
🚧 Files skipped from review as they are similar to previous changes (6)
- requirements_test.txt
- custom_components/plugwise_usb/strings.json
- custom_components/plugwise_usb/manifest.json
- custom_components/plugwise_usb/button.py
- custom_components/plugwise_usb/translations/nl.json
- custom_components/plugwise_usb/translations/en.json
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[uncategorized] ~10-~10: Possible missing preposition found.
Context: ...ress 0, overwriting the existing data - Improve the energy-reset process, should result...
(AI_HYDRA_LEO_MISSING_TO)
🔇 Additional comments (2)
CHANGELOG.md (2)
5-5: Release entry format is correct.
The versionv0.55.0and date2025-06-22align with the existing changelog style.
7-7: Verify dependency bump consistency.
Please ensure thatmanifest.jsonand any test requirements have been updated to requireplugwise-usb==0.44.4, and that the linked release URL is correct.
dirixmjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description in strings.py and translations could be a little more clear.
"Reset energy log" maybe?
Otherwise ok for me.
CoMPaTech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of hard and complex work, nice @bouwew
|



Summary by CodeRabbit
New Features
Improvements
Chores
Documentation